Record witness access in EXTCODEHASH #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
commented
Feb 8, 2024
Comment on lines
+854
to
+866
| dummyContract := []byte{ | ||
| 0x60, 2, // PUSH1 2 | ||
| 0x60, 12, // PUSH1 12 | ||
| 0x60, 0x00, // PUSH1 0 | ||
| 0x39, // CODECOPY | ||
|
|
||
| 0x60, 2, // PUSH1 2 | ||
| 0x60, 0x00, // PUSH1 0 | ||
| 0xF3, // RETURN | ||
|
|
||
| // Contract that auto-calls EXTCODEHASH | ||
| 0x60, 42, // PUSH1 42 | ||
| } |
There was a problem hiding this comment.
Deploy dummyContract so we have some contract to use EXTCODEHASH later.
Comment on lines
+868
to
+882
| extCodeHashContract := []byte{ | ||
| 0x60, 22, // PUSH1 22 | ||
| 0x60, 12, // PUSH1 12 | ||
| 0x60, 0x00, // PUSH1 0 | ||
| 0x39, // CODECOPY | ||
|
|
||
| 0x60, 22, // PUSH1 22 | ||
| 0x60, 0x00, // PUSH1 0 | ||
| 0xF3, // RETURN | ||
|
|
||
| // Contract that auto-calls EXTCODEHASH | ||
| 0x73, // PUSH20 | ||
| 0x3a, 0x22, 0x0f, 0x35, 0x12, 0x52, 0x08, 0x9d, 0x38, 0x5b, 0x29, 0xbe, 0xca, 0x14, 0xe2, 0x7f, 0x20, 0x4c, 0x29, 0x6a, | ||
| 0x3F, // EXTCODEHASH | ||
| } |
There was a problem hiding this comment.
Deploy another contract that actually makes the EXTCODEHASH to the previously deployed contract.
This was required to be super clear about witness checks. Initially, I made the dummy contract "auto call" EXTCODEHASH, but then is hard to distinguish why the witness have the contract code hash (e.g: from deployment or from EXTCODEHASH exec).
Comment on lines
+888
to
+894
| // Create dummy contract. | ||
| tx, _ := types.SignTx(types.NewContractCreation(0, big.NewInt(0), 100_000, big.NewInt(875000000), dummyContract), signer, testKey) | ||
| gen.AddTx(tx) | ||
|
|
||
| // Create contract with EXTCODEHASH opcode. | ||
| tx, _ = types.SignTx(types.NewContractCreation(1, big.NewInt(0), 100_000, big.NewInt(875000000), extCodeHashContract), signer, testKey) | ||
| gen.AddTx(tx) |
There was a problem hiding this comment.
In the first block deploy both contracts.
Comment on lines
+896
to
+897
| tx, _ := types.SignTx(types.NewTransaction(2, extCodeHashContractAddr, big.NewInt(0), 100_000, big.NewInt(875000000), nil), signer, testKey) | ||
| gen.AddTx(tx) |
There was a problem hiding this comment.
In the next block do the actual execution, so if the witness shows the contract code hash address then we know its' from EXTCODEHASH execution and not contract deployments.
| if codeHashStateDiff.CurrentValue == nil { | ||
| t.Fatalf("codeHash.CurrentValue must not be empty") | ||
| } | ||
| expCodeHash := crypto.Keccak256Hash(dummyContract[12:]) |
There was a problem hiding this comment.
Avoiding magical hashes, so we know it's correct.
g11tech
approved these changes
Feb 8, 2024
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
force-pushed
the
jsign-extcodehash-witness
branch
from
7354ccc to
e400860
Compare
gballet
pushed a commit
that referenced
this pull request
May 7, 2024
* instructions: add access witness recording for EXTCODEHASH * add test for EXTCODEHASH witness recording * add test for access witness EXTCODEHASH Signed-off-by: Ignacio Hagopian <[email protected]> * do not touch version Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
* instructions: add access witness recording for EXTCODEHASH * add test for EXTCODEHASH witness recording * add test for access witness EXTCODEHASH Signed-off-by: Ignacio Hagopian <[email protected]> * do not touch version Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
* instructions: add access witness recording for EXTCODEHASH * add test for EXTCODEHASH witness recording * add test for access witness EXTCODEHASH Signed-off-by: Ignacio Hagopian <[email protected]> * do not touch version Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds access witness recording for EXTCODEHASH